Add Authorization Bearer token pattern#124
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Introduces support for redacting Authorization: Bearer <token> headers in the logging middleware.
- Adds a case-insensitive regex to
lib/patterns/default.rbto match and redact bearer tokens. - Expands
spec/lib/redacting_logger_spec.rbwith a test case ensuring the new header is redacted.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/patterns/default.rb | Adds a regex pattern for case-insensitive Authorization: Bearer token redaction |
| spec/lib/redacting_logger_spec.rb | Adds a test case to verify redaction of the bearer header |
Comments suppressed due to low confidence (1)
spec/lib/redacting_logger_spec.rb:166
- It may be useful to add a test case for a lowercase
authorization: bearerheader to ensure the pattern's case-insensitivity is correctly applied.
message: '-H "Authorization: Bearer ab123456789a1abcd1~_.-+456ABCDE=" -H "Content-Type: application/json"',
look
previously approved these changes
May 22, 2025
Member
look
left a comment
look
left a comment
There was a problem hiding this comment.
Thanks for upstreaming this @rewinfrey.
GrantBirki
previously approved these changes
May 26, 2025
Contributor
GrantBirki
left a comment
GrantBirki
left a comment
There was a problem hiding this comment.
@rewinfrey thank you very much for upstreaming these changes and helping to improve this gem! 🙇 ❤️
GrantBirki
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out from https://github.com/github/blackbird-mw/pull/3756.
This adds a regex pattern for redacting
Authorization: Bearer <token>.